Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use JDKxu config over JDKx config wherever possible #1069

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Use JDKxu config over JDKx config wherever possible #1069

merged 2 commits into from
Jul 12, 2024

Conversation

adamfarley
Copy link
Contributor

The affected code seems to use JDKx config even if the more recent jdkxu config is available.

This is incorrect, and should be resolved.

Actioned to resolve the General retrospective comment here.

@adamfarley adamfarley requested a review from sxa July 3, 2024 12:34
@adamfarley adamfarley self-assigned this Jul 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

@adamfarley
Copy link
Contributor Author

run tests

@adamfarley adamfarley enabled auto-merge (squash) July 3, 2024 14:00
@adamfarley adamfarley mentioned this pull request Jul 3, 2024
Closed
9 tasks
@eclipse-temurin-bot
Copy link
Collaborator

 PR TESTER RESULT 

✅ All pipelines passed! ✅

@adamfarley
Copy link
Contributor Author

@karianna - Does this address your concern? Are we good to merge?

@adamfarley adamfarley merged commit 6893c29 into adoptium:master Jul 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxa sxa sxa approved these changes

@karianna karianna karianna approved these changes

Assignees

@adamfarley adamfarley

Labels
jenkins-pipeline
Projects
No open projects
2024 3Q Adoptium Plan
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adamfarley @eclipse-temurin-bot @karianna @sxa